Commits
- Commit:
c3da48cb383f5c0cc034d7441682b22be13e5596a97d97d2d26e94b096b02364- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
CHANGES for 0.126
- Commit:
271316db27aae9b801de409d8097e6dcdf593baa517ce77328b466c2ce7bc7a6- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
sync dist file list
- Commit:
08c39ec3233041ae39f4885f95162af964a1c19c8c6cff6c8ed5e357cb893d5e- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
repair gotsysd build after network sha256 changes
- Commit:
3de97fadcf85613d1d2b0cfc4e84fd11eaec1c63ef96cacfbf264a12d1db69d3- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
repair gotd build broken by initial sha256 network support commit
- Commit:
4c8a36a97a40a2c127ffe279f72f8d634320fcdfc931e75d1546a0192b5c75c2- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
fix test_send_gitconfig for sha256 mode
- Commit:
838995d3973030de74c63ada848e3470c8a239351d1fd6b7a5b40151ed41a5f0- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
make test_checkout_repo_with_unknown_extension pass with sha1 and sha256
- Commit:
9a47928d7746d1846dc6abd053c080bfbcf6640fe3fa3e30ce16e2ff69d0dc97- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
always create initial Git config files when cloning
For SHA256 network support we must always create configuration files
as soon as server-side capabilities have been announced. Otherwise we
cannot reliably stamp the repository with the correct object format.
test_clone_dangling_headref is triggering this condition. We don't
have symrefs (only an explicit -b foo) so we never switch the repo
to sha256 format.
Requiring symrefs for creation of the initial Git config is no longer
necessary. If the server does not send announce a HEAD symref as part
of its capabilities then we have workarounds for this in got.c:cmd_clone().
The workarounds did not yet exist when the condition removed here was added.
- Commit:
890ae5277c00c0e48ef315804501c6f51abecfd5f11bd42fc838bf9bf355b51f- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
regress/cmdline: make all tests run with sha256
- Commit:
500a56c373b32d1b30daa7bcef127b81b59bf8d504f4c627143f9db2278b8cac- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Stefan Sperling <stsp@stsp.name>
- Date:
regress/cmdline: fix clone for sha256
- Commit:
b2d03dc5144c84f83c964b09bb42e403cd38c46d45ca3c82712b58dcf22611b8- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Stefan Sperling <stsp@stsp.name>
- Date:
got-fetch-pack: send_object_format() before send_fetch_symref()
otherwise we fail in fetch.c because we get zero (GOT_HASH_SHA1) as
object format when we might not expect it.
- Commit:
04284d5dc05ec467c10c7f4adc727769c664c16aaf6ea9a96d5f7ec9ca59009c- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Stefan Sperling <stsp@stsp.name>
- Date:
revert chunk; match object-format in gitproto match_capability
unbreaks send
- Commit:
7d4ae36f214d9221227adf259583884af482804807229b606facbca07cc46684- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Stefan Sperling <stsp@stsp.name>
- Date:
stsp stuff
- Commit:
e3ea4980200fcb01474ef5c204b5af1b3f81113d18beb5b9005af4b315156a48- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Stefan Sperling <stsp@stsp.name>
- Date:
initial sha256 support in the network protocol
fetch and send to/from sha256 repositories now actually works. many
thanks to runxiyu on irc for making me realize that we don't actually
need to support the Git protocol v2 for sha256, but just enable the
capability, which is what this diff does.
Clone still needs work. For now, a workaround is to create an empty
sha256 repository locally, add the remote and fetch instead.
No regress test enabled yet since they all depend on clone to work.
- Commit:
1042480b8e6f3f1787cfadc08cdf03761fef21314e9a34ccc0b53a9ad401d22a- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
we cannot run test_checkout_bad_tree_entry with sha256 yet
This test would require an equivalent bundle file in sha256 format.
Mark it as no-sha256 for now.
- Commit:
2e2e941dbf1ed285af45c5a5029c00452961ff0582627161661326dc26ae28e4- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
fix test failures with Git 2.54.
As of Git 2.54, the automatic maintenance strategy now defaults to
"geometric repacking", which writes multi-pack-index (MIDX) files
which Game of Trees lacks support for. If 'gotadmin cleanup' is
run on repositories using MIDX files then 'git fsck' will complain.
To keep test_cleanup_redundant_pack_files passing we can disable
automatic maintenance on Git repositories used by the test suite.
Which our test suite should have been doing anyway for predictable
results.
Problem first reported by naddy@ in
https://marc.gameoftrees.org/mail/1778459401.3079_0.html
Thanks to Patrik Steinhardt for explaining the Git-side changes to me.
- Commit:
567001ae976c0f92835613778c51db71afc405020301113a2d80e1f7fb1dbd99- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
fix serving a branch of unrelated history with gotd
Fix a case where gotd started sending pack progress output in response
to the client sending 'done', without any ACK or NAK in-between.
I saw this happen when trying to fetch an unrelated main branch from
gotd, with completely different history and initial root commit,
into an existing repository with a different main branch history.
Add test cases covering 'got fetch' against a git-upload-pack server (is
always passing), and 'got fetch' and 'git fetch' against gotd (was not
passing, i.e. both got and git fail to fetch unless this fix is applied).
ok op@
- Commit:
dada3c2badb26038d48e8de5f367ce086e5afaef6c7d694220e69b44e82a1761- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
do not forget to add loose parent commits to pack files
Fixes problems where 'got send' omits some parent commits from history
which ought to be sent to the server.
ok op@
- Commit:
382a9af4712fd09e47db1ede3dbae7c5139ebd49d68b5db84f5f6829e32be705- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
make regression test check whether $testroot/wt/../pwned gets created
- Commit:
d40159dedb256c4362e29173d0ec51fb840d931dc9ec295e42596cf2616631f6- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
store repository test data in a bundle to avoid a dependency on xxd
pointed out by naddy, we cannot reasonably expect xxd to exist everywhere
- Commit:
f74016d64332a91c71bac8b3ac8dc3f53ca56c7c6640fc44d20655ba09301444- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
bump version number
- Commit:
39c8373c7f7ec5f280e9095e81366c239a94f58fd2ce245504b1a8dca8237bdf- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
CHANGES for 0.125
- Commit:
7ca4af00fed138807509bf931f240ea9130f6d5566d75b8224c0580710a7b354- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
prevent NULL pointer dereferences when empty tree objects are encountered
Found by me while investigating the issues reported by Runxi Yu.
The test added here would trigger a crash in tog using a modified version
of Runxi Yu's bug reproduction script.
- Commit:
a48420af0e6a32a59f5fbcc7c78fa642ca2d89a832de5aad1f6234ddf212b326- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
avoid checking out tree entry names "." and "..", and names containing "/"
This would allow malicious repositories to perform arbitrary file overwrites
with user permissions via crafted tree entry names. The regression test
added here shows that such repositories can be trivially created with Git.
On operating systems which lack unveil(2) any user-writable file could be
created or changed. On OpenBSD, unveil(2) restricts arbitrary write access
to the work tree itself and the /tmp directory.
Problem reported me by Runxi Yu, along with a reproduction script I could
use to write the regression test. Thanks!
- Commit:
a3e261487a807988b92001ccb748c29465526cb3f5be0bf2c2b6de6123a1a27b- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
reject attempts to put versioned files into .git, .got, or .cvg directories
Versioned files inside the work tree's meta-data .got directory could be
created during 'got checkout' or changed during 'got update'. Files in
the meta-data directory should never be under version control, yet the
implementation unfortunately allowed this.
Which provides a way for malicious repositories to configure remote servers
stored in .got/got.conf which would then be used by the fetch and send
commands.
Problem spotted by Runxi Yu and reported to me on IRC.
testing + ok Thomas Adam
- Commit:
06285208fae857821ae1f92a774f2bc91c71ec7a9f5817693caf26bb5f88fad7- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
cleanup: fix redundant pack file removal when repository contains symlinks
Add symlinks to the set of traversed object IDs during cleanup. Otherwise,
packfiles which contain blobs that are symlinks will always be marked as
containing unreferenced objects and 'gotadmin cleanup' will not remove them.
This can result in an explosion of redundant packfiles if 'gotadmin cleanup'
is run at regular intervals, and if the cleanup -a option is not used.
I am unsure how to write a test case for this fix without making additional
changes to the cleanup command. The tests run cleanup -a to bypass the mtime
staleness safety check. This will never hit the problematic case fixed here.
Reproducing the problem would require a test which waits for the (currently)
hard-coded interval of 600 seconds before running cleanup.
If we added a way to tweak the mtime threshold from tests then we could
probably add a test case which covers this issue.
Problem found because gothub.org backups were taking much more disk space
than expected.
ok runxi yu, op@
