Commits
- Commit:
5e16bab2f58509fbeda99debd61f342e1d7ea1d5d51f35c3d69d58f393cfe884- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
CHANGES for 0.124
- Commit:
0f711f3c9b1cf1f9745b6011b0a823963b0b5d57554e7e643370eb79fbc9ce1d- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
sync dist file list
- Commit:
9e4a562e0149ac401a5da1e378b807a8318069a7929dd72d0a1335d61c80d376- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
prevent spurious test failure due to wrong commit timestamp being checked
- Commit:
c381a9c462498f67f93338e33ae530dd95b57dbd3e40e4aede7d89db0e5edb52- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
make gotwebd display logged-in usernames in case of group-membership auth
In cases where the access identifier is a group name, gotwebd would
display a group name rather than the name of the authenticated user
in the "Logged in as" banner. We always want to display the user name.
review/ok runxiyu
- Commit:
de3ada86e34282186fb0fffb169c74e4cca0216f9bbb1d053aa78c440c94c36c- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
reject non-UTF-8-encoded reference names in gotsys.conf
The docs already stated that reference names must be UTF-8.
- Commit:
b4a6572aba7a25a0c77fd76a5ea98a907e01a06cd3020badec95b984193649d3- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
document that site owner and repository description may use UTF-8
- Commit:
1f011542bba73f3c01b674a1630e9a2df9bc5b31a41bd620b39ee4f410fe715e- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
add a test case for UTF-8 repository owner names in gotsys.conf
test and review/ok Kyle Ackerman
- Commit:
38593aa7708aaf3555b8769576a06d7b98bd16f2e794700a37920a9cf375b9c1- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
allow UTF-8 in gotsys string values
test and review/ok Kyle Ackerman
- Commit:
6e1d6bccb3a2bc6497c88df19234d01b67463d09d521ff5f79d11d316966124d- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
validate UTF-8 in quoted strings in gotsys.conf
test and review/ok Kyle Ackerman
- Commit:
9c50af0ee8deb8c773d10b1a636ed2fe2b13f4c8b5394c379274f620a2cc06b2- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
rename decode() to utf8d_decode() for namespacing reasons
- Commit:
286a6d0bc1f665f60c520a97dd62f72878864cb57b7d44fb63a04f9238e50b91- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
move utf8d.h to lib/
- Commit:
63bf3e483ff85bb146c97248faef8b97942d274883966048b66bcc9360dd572f- From:
- Kyle Ackerman <kack@kyleackerman.net>
- Date:
Plug a memory leak in libexec got-read-commit
When got-read-commit receives an imsg of type
GOT_IMSG_STOP, it attempts to exit the main loop
and leaks the last imsg. This commmit frees the
the imsg before breaking from the main loop.
ok stsp@
- Commit:
44f664b17ed79e4c7c4f23ca3c014101e8a70485f0864f45e4b75ccbeae4c0c9- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
typo fix
- Commit:
8014df0d405ec7c719abd9d73b27bdbf9806c040ed5455579d3d84b2b6973c13- From:
- Henry Ford <henryfordkjv@gmail.com>
- Via:
- Stefan Sperling <stsp@stsp.name>
- Date:
prevent non-root users from blocking gotctl reload requests
Patch by: Henry Ford
The bug fixed here is as follows, in Henry's words:
If a GOTD_IMSG_RELOAD message is sent by a non root user, then gotd(8) will
deny the request. However, gotd(8) will accept a GOTD_IMSG_RELOAD_SECRETS
message from any client regardless of their uid.
After receiving a GOTD_IMSG_RELOAD_SECRETS message gotd(8) will not accept
another such message until it receives a GOTD_IMSG_RELOAD message to complete
the reload request.
Thus, a non root user can block any future gotctl(8) reload requests from
succeeding by sending a GOTD_IMSG_RELOAD_SECRETS message to gotd(8).
You can reproduce this by running the following commands with gotd(8) running:
$ gotctl reload -c /dev/null
gotctl: reload: Operation not permitted
# gotctl reload
gotctl: received unexpected privsep message
- Commit:
4adf9a5039c8b1ceaf7020883aa9d00d8bcf17610c7bad027c74ef82da626a00- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
expand tab characters in log messages displayed by tog diff
Ever since tog started indenting the log message by one space character,
lines containing tab characters ended up using wrong indentation.
Fix this by expanding tabs to spaces before applying extra indentation.
To see the effect of this fix, start tog in diff.git as follows:
tog diff -c dc306c6bd88271ab911e205539974da98be82d17
- Commit:
c52931e3617c3dce87bce08dc21e14d45ba5cb177b82c888dddfc20e88147d9e- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
add a todo item for gotsysd
- Commit:
721f64a084419c8d6209f347d8e08d5722e17c02826f11b2b4006c886608353d- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
remove a gotwebd TODO item which is done
- Commit:
c91780cc2c04f386be61b1e65bf767a6e65b10f43826a876251b33695f04a36c- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
remove a todo item for 'got fetch' which has been done for a long time
- Commit:
64651d9f7a1a3b5c7c5ef02e1f1fe6a2a5c0be69d35ca20316b2e19d08f83e0c- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
remove a gotd todo item which is done
- Commit:
80c5ade239bd9084ad0209a43b5ec726f9d59ab1456513fe8c16c87dc2090f39- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
add test coverage for gotsys.conf being deleted and restored
- Commit:
484fa7b085e0ecfb9f4631de83511af30a3f7bb96a5f9b114ba50a91f7576820- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
amend previous fix: commits and trees can be missing from pack file, too
Testing these cases in our test suite would be inconvenient since it
would require a custom tool to send bad pack files with missing objects.
- Commit:
96dc74b56cfdeb04fe0a4fa12c87ff287fe874f712c90c7e7ed5f460e76f4130- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
fix gotd wrongly complaining about a missing gotsys.conf in pack files
Handle the case where gotsys.conf is legitimately missing from the
uploaded pack file. Only reject the pack file if the content of a
missing gotsys.conf file cannot be found anywhere in the repository.
Add test coverage.
- Commit:
4d6259f764dcf94a262d688cac3aa166c6085ef4c8f241846d533cb5cc541097- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
plug a tree object leak in gotd/repo_write get_content_from_packfile()
- Commit:
b8fcb4254a166c48c48a511248ce14b7fedbb26a9016b15800ea7c8d452ff696- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
fix a segfault in tog worktree_entries_reveal()
tog crashed on me while using the & search feature. The coredump
shows that *first was NULL, so we need to catch this case here.
- Commit:
30c86dc2e71cef1d5c7c58bf5c3c454a49104c9ef197fef5f4753531f556ce51- From:
- Thomas Adam <thomas@xteddy.org>
- Date:
gotwebd: propagate chroot path to child processes
The config file is read in the parent process, but the chroot value is
never passed to the children when execvp() is called. This means that
the default value of "/var/www" is used, despite whatever the user has
set in gotwebd.conf
OK @op, @stsp
