Commits
- Commit:
39c8373c7f7ec5f280e9095e81366c239a94f58fd2ce245504b1a8dca8237bdf- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
CHANGES for 0.125
- Commit:
7ca4af00fed138807509bf931f240ea9130f6d5566d75b8224c0580710a7b354- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
prevent NULL pointer dereferences when empty tree objects are encountered
Found by me while investigating the issues reported by Runxi Yu.
The test added here would trigger a crash in tog using a modified version
of Runxi Yu's bug reproduction script.
- Commit:
a48420af0e6a32a59f5fbcc7c78fa642ca2d89a832de5aad1f6234ddf212b326- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
avoid checking out tree entry names "." and "..", and names containing "/"
This would allow malicious repositories to perform arbitrary file overwrites
with user permissions via crafted tree entry names. The regression test
added here shows that such repositories can be trivially created with Git.
On operating systems which lack unveil(2) any user-writable file could be
created or changed. On OpenBSD, unveil(2) restricts arbitrary write access
to the work tree itself and the /tmp directory.
Problem reported me by Runxi Yu, along with a reproduction script I could
use to write the regression test. Thanks!
- Commit:
a3e261487a807988b92001ccb748c29465526cb3f5be0bf2c2b6de6123a1a27b- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
reject attempts to put versioned files into .git, .got, or .cvg directories
Versioned files inside the work tree's meta-data .got directory could be
created during 'got checkout' or changed during 'got update'. Files in
the meta-data directory should never be under version control, yet the
implementation unfortunately allowed this.
Which provides a way for malicious repositories to configure remote servers
stored in .got/got.conf which would then be used by the fetch and send
commands.
Problem spotted by Runxi Yu and reported to me on IRC.
testing + ok Thomas Adam
- Commit:
06285208fae857821ae1f92a774f2bc91c71ec7a9f5817693caf26bb5f88fad7- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
cleanup: fix redundant pack file removal when repository contains symlinks
Add symlinks to the set of traversed object IDs during cleanup. Otherwise,
packfiles which contain blobs that are symlinks will always be marked as
containing unreferenced objects and 'gotadmin cleanup' will not remove them.
This can result in an explosion of redundant packfiles if 'gotadmin cleanup'
is run at regular intervals, and if the cleanup -a option is not used.
I am unsure how to write a test case for this fix without making additional
changes to the cleanup command. The tests run cleanup -a to bypass the mtime
staleness safety check. This will never hit the problematic case fixed here.
Reproducing the problem would require a test which waits for the (currently)
hard-coded interval of 600 seconds before running cleanup.
If we added a way to tweak the mtime threshold from tests then we could
probably add a test case which covers this issue.
Problem found because gothub.org backups were taking much more disk space
than expected.
ok runxi yu, op@
- Commit:
f3243aa5875dfd29e54bed572bb4f5e040e6a2618b56a4294acc04fbef092405- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
improve test coverage of send_merge_commit
I am seeing cases where an automatic git mirroring sync job apparently
fails to send all parents of a merge commit occasionally. My attempts to
reproduce this in the test suite have failed so far. But anyway, this
test should be checking whether all required commits have reached the
destination repository, so let's expand test coverage accordingly.
- Commit:
871be30ab9adaa3e16f3724562ff23643aa9dac00354bb557876921a131805d9- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
bump version number
- Commit:
5e16bab2f58509fbeda99debd61f342e1d7ea1d5d51f35c3d69d58f393cfe884- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
CHANGES for 0.124
- Commit:
0f711f3c9b1cf1f9745b6011b0a823963b0b5d57554e7e643370eb79fbc9ce1d- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
sync dist file list
- Commit:
9e4a562e0149ac401a5da1e378b807a8318069a7929dd72d0a1335d61c80d376- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
prevent spurious test failure due to wrong commit timestamp being checked
- Commit:
c381a9c462498f67f93338e33ae530dd95b57dbd3e40e4aede7d89db0e5edb52- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
make gotwebd display logged-in usernames in case of group-membership auth
In cases where the access identifier is a group name, gotwebd would
display a group name rather than the name of the authenticated user
in the "Logged in as" banner. We always want to display the user name.
review/ok runxiyu
- Commit:
de3ada86e34282186fb0fffb169c74e4cca0216f9bbb1d053aa78c440c94c36c- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
reject non-UTF-8-encoded reference names in gotsys.conf
The docs already stated that reference names must be UTF-8.
- Commit:
b4a6572aba7a25a0c77fd76a5ea98a907e01a06cd3020badec95b984193649d3- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
document that site owner and repository description may use UTF-8
- Commit:
1f011542bba73f3c01b674a1630e9a2df9bc5b31a41bd620b39ee4f410fe715e- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
add a test case for UTF-8 repository owner names in gotsys.conf
test and review/ok Kyle Ackerman
- Commit:
38593aa7708aaf3555b8769576a06d7b98bd16f2e794700a37920a9cf375b9c1- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
allow UTF-8 in gotsys string values
test and review/ok Kyle Ackerman
- Commit:
6e1d6bccb3a2bc6497c88df19234d01b67463d09d521ff5f79d11d316966124d- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
validate UTF-8 in quoted strings in gotsys.conf
test and review/ok Kyle Ackerman
- Commit:
9c50af0ee8deb8c773d10b1a636ed2fe2b13f4c8b5394c379274f620a2cc06b2- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
rename decode() to utf8d_decode() for namespacing reasons
- Commit:
286a6d0bc1f665f60c520a97dd62f72878864cb57b7d44fb63a04f9238e50b91- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
move utf8d.h to lib/
- Commit:
63bf3e483ff85bb146c97248faef8b97942d274883966048b66bcc9360dd572f- From:
- Kyle Ackerman <kack@kyleackerman.net>
- Date:
Plug a memory leak in libexec got-read-commit
When got-read-commit receives an imsg of type
GOT_IMSG_STOP, it attempts to exit the main loop
and leaks the last imsg. This commmit frees the
the imsg before breaking from the main loop.
ok stsp@
- Commit:
44f664b17ed79e4c7c4f23ca3c014101e8a70485f0864f45e4b75ccbeae4c0c9- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
typo fix
- Commit:
8014df0d405ec7c719abd9d73b27bdbf9806c040ed5455579d3d84b2b6973c13- From:
- Henry Ford <henryfordkjv@gmail.com>
- Via:
- Stefan Sperling <stsp@stsp.name>
- Date:
prevent non-root users from blocking gotctl reload requests
Patch by: Henry Ford
The bug fixed here is as follows, in Henry's words:
If a GOTD_IMSG_RELOAD message is sent by a non root user, then gotd(8) will
deny the request. However, gotd(8) will accept a GOTD_IMSG_RELOAD_SECRETS
message from any client regardless of their uid.
After receiving a GOTD_IMSG_RELOAD_SECRETS message gotd(8) will not accept
another such message until it receives a GOTD_IMSG_RELOAD message to complete
the reload request.
Thus, a non root user can block any future gotctl(8) reload requests from
succeeding by sending a GOTD_IMSG_RELOAD_SECRETS message to gotd(8).
You can reproduce this by running the following commands with gotd(8) running:
$ gotctl reload -c /dev/null
gotctl: reload: Operation not permitted
# gotctl reload
gotctl: received unexpected privsep message
- Commit:
4adf9a5039c8b1ceaf7020883aa9d00d8bcf17610c7bad027c74ef82da626a00- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
expand tab characters in log messages displayed by tog diff
Ever since tog started indenting the log message by one space character,
lines containing tab characters ended up using wrong indentation.
Fix this by expanding tabs to spaces before applying extra indentation.
To see the effect of this fix, start tog in diff.git as follows:
tog diff -c dc306c6bd88271ab911e205539974da98be82d17
- Commit:
c52931e3617c3dce87bce08dc21e14d45ba5cb177b82c888dddfc20e88147d9e- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
add a todo item for gotsysd
- Commit:
721f64a084419c8d6209f347d8e08d5722e17c02826f11b2b4006c886608353d- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
remove a gotwebd TODO item which is done
- Commit:
c91780cc2c04f386be61b1e65bf767a6e65b10f43826a876251b33695f04a36c- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
remove a todo item for 'got fetch' which has been done for a long time
