Commit Briefs

5e16bab2f5 Stefan Sperling

CHANGES for 0.124 (tags/0.124)


0f711f3c9b Stefan Sperling

sync dist file list



c381a9c462 Stefan Sperling

make gotwebd display logged-in usernames in case of group-membership auth

In cases where the access identifier is a group name, gotwebd would display a group name rather than the name of the authenticated user in the "Logged in as" banner. We always want to display the user name. review/ok runxiyu


de3ada86e3 Stefan Sperling

reject non-UTF-8-encoded reference names in gotsys.conf

The docs already stated that reference names must be UTF-8.



1f011542bb Stefan Sperling

add a test case for UTF-8 repository owner names in gotsys.conf

test and review/ok Kyle Ackerman


38593aa770 Stefan Sperling

allow UTF-8 in gotsys string values

test and review/ok Kyle Ackerman


6e1d6bccb3 Stefan Sperling

validate UTF-8 in quoted strings in gotsys.conf

test and review/ok Kyle Ackerman


9c50af0ee8 Stefan Sperling

rename decode() to utf8d_decode() for namespacing reasons


286a6d0bc1 Stefan Sperling

move utf8d.h to lib/


63bf3e483f Kyle Ackerman

Plug a memory leak in libexec got-read-commit

When got-read-commit receives an imsg of type GOT_IMSG_STOP, it attempts to exit the main loop and leaks the last imsg. This commmit frees the the imsg before breaking from the main loop. ok stsp@


44f664b17e Stefan Sperling

typo fix


8014df0d40 Stefan Sperling

prevent non-root users from blocking gotctl reload requests

Patch by: Henry Ford The bug fixed here is as follows, in Henry's words: If a GOTD_IMSG_RELOAD message is sent by a non root user, then gotd(8) will deny the request. However, gotd(8) will accept a GOTD_IMSG_RELOAD_SECRETS message from any client regardless of their uid. After receiving a GOTD_IMSG_RELOAD_SECRETS message gotd(8) will not accept another such message until it receives a GOTD_IMSG_RELOAD message to complete the reload request. Thus, a non root user can block any future gotctl(8) reload requests from succeeding by sending a GOTD_IMSG_RELOAD_SECRETS message to gotd(8). You can reproduce this by running the following commands with gotd(8) running: $ gotctl reload -c /dev/null gotctl: reload: Operation not permitted # gotctl reload gotctl: received unexpected privsep message


4adf9a5039 Stefan Sperling

expand tab characters in log messages displayed by tog diff

Ever since tog started indenting the log message by one space character, lines containing tab characters ended up using wrong indentation. Fix this by expanding tabs to spaces before applying extra indentation. To see the effect of this fix, start tog in diff.git as follows: tog diff -c dc306c6bd88271ab911e205539974da98be82d17


c52931e361 Stefan Sperling

add a todo item for gotsysd


721f64a084 Stefan Sperling

remove a gotwebd TODO item which is done



64651d9f7a Stefan Sperling

remove a gotd todo item which is done


80c5ade239 Stefan Sperling

add test coverage for gotsys.conf being deleted and restored


484fa7b085 Stefan Sperling

amend previous fix: commits and trees can be missing from pack file, too

Testing these cases in our test suite would be inconvenient since it would require a custom tool to send bad pack files with missing objects.


96dc74b56c Stefan Sperling

fix gotd wrongly complaining about a missing gotsys.conf in pack files

Handle the case where gotsys.conf is legitimately missing from the uploaded pack file. Only reject the pack file if the content of a missing gotsys.conf file cannot be found anywhere in the repository. Add test coverage.



b8fcb4254a Stefan Sperling

fix a segfault in tog worktree_entries_reveal()

tog crashed on me while using the & search feature. The coredump shows that *first was NULL, so we need to catch this case here.


30c86dc2e7 Thomas Adam

gotwebd: propagate chroot path to child processes

The config file is read in the parent process, but the chroot value is never passed to the children when execvp() is called. This means that the default value of "/var/www" is used, despite whatever the user has set in gotwebd.conf OK @op, @stsp