Commit Briefs

2c2cf8a3bd Stefan Sperling

CHANGES for 0.118 (tags/0.118)


2d43037349 Stefan Sperling

fix gotwebd regress failure introduced with querystring changes

A folder parameter addressing the root directory is expected to be an empty string rather than "/".


1aa169e576 Stefan Sperling

block gotwebd requests with paths that point outside the repository directory

ok op@


150487bcf0 Stefan Sperling

remove unused resp_event variable from gotwebd struct request


63e3561f20 Stefan Sperling

remove now unused 'gotweb_cur' variable from gotwebd


7e80e47cc1 Stefan Sperling

rename GOTWEBD_PROC_SERVER back to GOTWEBD_PROC_SOCKETS



48b4a683ef Stefan Sperling

remove the now unused "server_cnt" gotwebd variable


7a9137341f Stefan Sperling

move reyk's urldecode() copyright along




7c58d0a654 Stefan Sperling

move parsing of gotwebd querystrings into the pledge("stdio") process

Fields of the querystring structure become fixed-sized buffers for easy passing over imsg. This means we can no longer check pointers in this structure for NULL. Instead we have to check for empty strings. ok op@



98c4ff7492 Stefan Sperling

dispatch new requests to the least-busy gotwebd worker

Instead of distributing requests across workers in a round-robin fashion keep track of how many requests a given worker has queued and send new requests to the worker which has the least amount of work queued for it. This makes gotwebd much more responsive than stupid round-robin, even though the new strategy is still not optimal because different types of requests carry different cost. E.g. blaming a file is usually heavier than listing trees. But it might be good enough, for now. Let's try and see. ok op@


330d8550d2 Stefan Sperling

run just one gotwebd process which listens on sockets

The listen statement is a global configuration setting and it does not make sense to have more than one process listening. Run just one process which listens and is now again called "sockets", having been renamed from "sockets" to "server" some time ago. There is no good reason to run more than one "server" since server-specific settings from gotwebd.conf are selected based on the SERVER_NAME sent in the FastCGI request. This selection is handled by the gotweb.c process. ok op@



73d9b15393 Omar Polo

sockets_launch: simplify listen() handling

* clean up the SOCKS_BACKLOG versus SOMAXCONN usage * factor out just one listen() call * slightly improve the logging by showing the socket "name" too. ok stsp@


fab68aac68 Stefan Sperling

make gotsysd-managed repositories readable for the _gotd group

This allows making the repositories readable by other user accounts, such as _gotwebd, by adding those users to the _gotd group.



ff7a60f38e Stefan Sperling

make commit notifications only show the part of history unique to the branch

When a new branch is created, show all commits added on the branch relative to the HEAD branch, instead of showing just the tip commit. When branch history is changed with got send -f or git push -f, limit history traversal to a common ancestor with the HEAD branch, instead of walking the entire history until a root commit is found. Stacked branches will still show some extra history until they hit HEAD. This can be improved later. ok op@


517e90746d Stefan Sperling

move gotwebd fcgi record parsing into a dedicated process under pledge "stdio"

ok op@


89df1c542b Stefan Sperling

set gotwebd pledges according to address families of listening sockets

We were implicitly relying on "inet" to provide "unix". Be more specific. ok op@


284dcb53c6 Stefan Sperling

fix parallel processing of requests in gotwebd

Run just one server process per server declared in gotwebd.conf, instead of running additional server processes based on the "prefork" setting. The extra servers weren't actually used since they would all wake up together, only one of them would manage to accept a connection, and the others would fail wtth EWOULDBLOCK go back to sleep instead of handling other connections. Having a single listening process dispatch request across gotweb processes in a round-robin fashion actually allows requests to be processed in parallel as intended. We currently use a round-robin scheme which can still cause some requests to wait for a busy worker. This will be improved later. The "prefork" setting now only controls the number of gotweb workers which will be started. ok op@


18e47b6261 Stefan Sperling

plug memory leaks which are making gotwebd regress tests fail


3363f42b92 Stefan Sperling

make 'tog diff' show the repository name in names of patches written to /tmp

ok op@