Commit Briefs
CHANGES for 0.129 (tags/0.129)
plug a memory leak caused by duplicate ignore patterns
When pattern in ignore file is repeated, RB_INSERT() will return pointer to already existing element, not inserting new one, in this case we leak the pattern pointer. Patch by Mikhail Pchelin
fix a problem where 'got revert' errors out in a work tree with a path-prefix
The conditions which trigger this problem are as follows: - A path prefix must be set via got checkout -p. - A file which matches the name of the first component of the path prefix must exist in the work tree. This file can be unversioned. - A cherrypick or backout log message ref must exist for this work tree, i.e. 'got cherrypick' or 'got backout' must be run before attempting to revert changes. The error is thrown during the status walk which is supposed to find changes in the work tree which correspond to the log message's commit as recorded by 'got cherrypick' or 'got backout'. The fix is to make this status crawl path-prefix aware by stripping the prefix from all paths returned by the repository-side diff driver. ok thomas_adam
handle removal of UID_MAX und GID_MAX
The UID_MAX and GID_MAX macros are not portable, their use is prone to errors, and they will be removed from the OpenBSD headers shortly. ok stsp
do not add unversioned files to version control if a file addition is merged
Problem reported by Yann Lorwyn
gotwebd: drop mention of obsolete helper program directory
Noticed while reading the manual and setting things up: * got 0.111; 2025-04-22 - get rid of the gotwebd-specific libexec helpers in /var/www/bin/gotwebd
remove empty dangling directories within refs/ when removing references
Otherwise attempts to create a new reference using the parent reference name will fail. Problem spotted and test written by martijn@
Add test coverage for reusing a deleted reference's parent name
Currently fails because we run into an existing empty directory on disk if the relevant references weren't packed. Patch by martijn@
add a TODO item got update -n feature idea
suggested by Cara, Tom Smyth, and jtt
list security issue contacts in README
We do not have a private mailing list for this yet, so provide a list of maintainers to send email to. So far there have been (almost?) no security issue reports from third-parties, which is nice. Our waters are calm. But it won't hurt to provide a list of private contacts, just in case.
CHANGES for 0.128 (tags/0.128)
fix bogus "no such file or directory" errors seen during histedit
got_object_blob_file_create() expects an absolute on-disk path, so provide one. No test case added yet. I encountered the problem in a private repository and tested this fix there. I could not yet trigger the bug on purpose.
fix segfault in error handling path of gotsys-apply-conf
Do not try to send errors via a gotsysd_iev which was already freed. Should fix a segfault observed while running 'gotsys apply' without having gotd running.
