commit fe092c4f2a9d752a4c15ed2a4e4e2effea8bac141733e7974ace69519047e5c7 from: Stefan Sperling date: Mon Jul 21 13:36:38 2025 UTC reset file position when reusing per-repository temporary files When reusing a temporary file, do not forget to reset its file position to zero. Otherwise, opening multiple raw objects in a row can fail during delta application with an unexpected file size reported by stat(2). Problem reported by Aaron Lin Problem reproduced and fix verified with a repository provided by Aaron. I have unsuccessfully tried to write a regression test for this. ok op@ commit - 8dff753aba8ff58e70bb6931a324ea5cdb1fc48cf529505d9149e4f2dba6b11b commit + fe092c4f2a9d752a4c15ed2a4e4e2effea8bac141733e7974ace69519047e5c7 blob - 54583e6bddf2c7688ee0d67e64a68eb35375616fb465371e8fcac84c13487335 blob + 26fd5d50fee8d727d253f429e1d0db431a1b7422c6a5f2f0c8cbd9068d3cfe72 --- lib/repository.c +++ lib/repository.c @@ -399,6 +399,8 @@ got_repo_temp_fds_get(int *fd, int *idx, struct got_re if (repo->tempfiles[i] != -1) { if (ftruncate(repo->tempfiles[i], 0L) == -1) return got_error_from_errno("ftruncate"); + if (lseek(repo->tempfiles[i], 0L, SEEK_SET) == -1) + return got_error_from_errno("lseek"); *fd = repo->tempfiles[i]; *idx = i; repo->tempfile_use_mask |= (1 << i);