commit f6f8289012aca18a8636d0d313bd4b3fc813e508c6d6110d5d6d972bcda27b34 from: Mark Jamsek date: Mon Jan 6 01:31:48 2025 UTC use got_object_id_queue_free() instead of hand-rolled code ok stsp@ commit - 007ea3163e808d98030269b64e37e8181deb372053bbc0ee50141b976b4d403b commit + f6f8289012aca18a8636d0d313bd4b3fc813e508c6d6110d5d6d972bcda27b34 blob - 96a1ef9e5975302ff81a487c2bd6c7997197b8d843dd303f7673bbcf834e22a4 blob + 1edfc518c1d73e984a939fce8ca08ad7cc6698249251d7a1420ae6bdfde5541a --- cvg/cvg.c +++ cvg/cvg.c @@ -3913,11 +3913,7 @@ print_commits(struct got_object_id *root_id, struct go } } done: - while (!STAILQ_EMPTY(&reversed_commits)) { - qid = STAILQ_FIRST(&reversed_commits); - STAILQ_REMOVE_HEAD(&reversed_commits, entry); - got_object_qid_free(qid); - } + got_object_id_queue_free(&reversed_commits); got_pathlist_free(&changed_paths, GOT_PATHLIST_FREE_ALL); if (search_pattern) regfree(®ex); blob - 8e386634405c11908425fe85482b73e836bb4bab4a3961b15313d78ae4c3210c blob + 03f284758f7e85b2093c8bc4789ab6d244e070507a903739b5633036f321c18b --- got/got.c +++ got/got.c @@ -4691,11 +4691,7 @@ print_commits(struct got_object_id *root_id, struct go } } done: - while (!STAILQ_EMPTY(&reversed_commits)) { - qid = STAILQ_FIRST(&reversed_commits); - STAILQ_REMOVE_HEAD(&reversed_commits, entry); - got_object_qid_free(qid); - } + got_object_id_queue_free(&reversed_commits); got_pathlist_free(&changed_paths, GOT_PATHLIST_FREE_ALL); if (search_pattern) regfree(®ex); blob - 7604d5929de74a67fc327e1995c5a6869398bcbed1db17dc5ddcc94c04d4060d blob + 2fbcebb9ab1795626e53604b2955ee51c91f1493db52aa4c07878d201cd0da38 --- gotd/repo_write.c +++ gotd/repo_write.c @@ -1955,11 +1955,7 @@ print_commits(struct got_object_id *root_id, struct go done: if (commit) got_object_commit_close(commit); - while (!STAILQ_EMPTY(&reversed_commits)) { - qid = STAILQ_FIRST(&reversed_commits); - STAILQ_REMOVE_HEAD(&reversed_commits, entry); - got_object_qid_free(qid); - } + got_object_id_queue_free(&reversed_commits); got_pathlist_free(&changed_paths, GOT_PATHLIST_FREE_ALL); got_commit_graph_close(graph); return err; blob - 9f1cf3cf1186f291e0fff5e5ebe6117edef0954ab1af4965c9bcf943757f23eb blob + 68d8b28ee6a1fa9059476803accebcf78a6a7097467664096f18c0766d3932a4 --- tog/tog.c +++ tog/tog.c @@ -8379,12 +8379,7 @@ close_blame_view(struct tog_view *view) if (s->blame.thread) err = stop_blame(&s->blame); - while (!STAILQ_EMPTY(&s->blamed_commits)) { - struct got_object_qid *blamed_commit; - blamed_commit = STAILQ_FIRST(&s->blamed_commits); - STAILQ_REMOVE_HEAD(&s->blamed_commits, entry); - got_object_qid_free(blamed_commit); - } + got_object_id_queue_free(&s->blamed_commits); if (using_mock_io) { struct tog_blame_thread_args *bta = &s->blame.thread_args;