commit e116395e102eeeb0790d44fe53b18fec50fbd09c552ae11fd79a0433eb693b25 from: Stefan Sperling date: Fri Jul 18 12:24:34 2025 UTC fix gotd reload when /etc/gotd-secrets.conf is used When sending the configuration to the newly reloaded gotd process we must send the path to the secrets file if it is being used. Otherwise, the new process will die with "unexpected amount of data received in imsg" errors. Test coverage will be added later as part of some new gotsysd tests which I have in progress. commit - ffca96789477456b045948733974ef18c7e5c18b93b28878c9468fb6d4f8d0ce commit + e116395e102eeeb0790d44fe53b18fec50fbd09c552ae11fd79a0433eb693b25 blob - ab58d2f9a439b51fcdcaee34e75235a3297358193c52734a46b8d84723b94b6a blob + 6ef51e8d4e9eb7d80c0bdbdd8bf85bfea4d79109d5a1984c02af8b2ab7d33cc7 --- gotd/gotd.c +++ gotd/gotd.c @@ -596,7 +596,10 @@ send_reload_config(struct gotd_imsgev *iev) } if (imsg_compose(&iev->ibuf, GOTD_IMSG_RELOAD_SECRETS, - GOTD_PROC_GOTD, gotd.pid, gotd_reload_secrets_fd, NULL, 0) == -1) { + GOTD_PROC_GOTD, gotd.pid, gotd_reload_secrets_fd, + gotd_reload_secrets_path ? gotd_reload_secrets_path : NULL, + gotd_reload_secrets_path ? strlen(gotd_reload_secrets_path) : 0) + == -1) { err = got_error_from_errno("imsg compose RELOAD_SECRETS"); goto done; }