commit c6e7f8f0dfe9a0aba3ba692b569ab12c382b9a667f7578db55877a13b8a56320 from: Stefan Sperling date: Sat Feb 1 15:32:59 2025 UTC avoid the needless check for set membership in got-read-pack as well The list of ids traversed here won't contain IDs already present in the set. commit - 60fe0273dafb9cf4b67ad182136e740d14d709d112e79b0d76315d9ad3fb58a9 commit + c6e7f8f0dfe9a0aba3ba692b569ab12c382b9a667f7578db55877a13b8a56320 blob - 3740f43d49205bcf0c498bff69c7f1d18a8ce28741eb44ea5c4a4b0a81c1f329 blob + e33ded2b00a80849c47879d594962e1b847e3a6b9cc13b25f915fa537d0fe76f --- libexec/got-read-pack/got-read-pack.c +++ libexec/got-read-pack/got-read-pack.c @@ -1739,11 +1739,9 @@ repaint_parent_commits(struct got_object_id *commit_id if (err) break; - if (!got_object_idset_contains(set, &pid->id)) { - err = got_object_idset_add(set, &pid->id, NULL); - if (err) - break; - } + err = got_object_idset_add(set, &pid->id, NULL); + if (err) + break; STAILQ_REMOVE_HEAD(&repaint, entry);