commit 8cc3cb21553ab10e45d1b3bdb9941c7994c6a9441ce4db312553871b3ad2baa1 from: Stefan Sperling date: Thu Aug 14 16:45:14 2025 UTC do not let got-read-pack paint parent commits which are not in its pack file If any parent commit of the current commit is missing, stop iterating and return control to the main process. Fixes a case where offloading to got-read-pack resulted in an effectively endless loop. ok op@ commit - c46b1605c71bd0ae9d2cfa477c55baa7b08a6a67c4009342fdca91a8ca606d44 commit + 8cc3cb21553ab10e45d1b3bdb9941c7994c6a9441ce4db312553871b3ad2baa1 blob - 97f43349c2bc957661f3bee6d040b01a21c7f3fc358b5453e16f356f86114427 blob + 081a7e736398ca7fab9f45ef245d606dd26d449752eb164a65de9ad63b0b80a9 --- libexec/got-read-pack/got-read-pack.c +++ libexec/got-read-pack/got-read-pack.c @@ -1798,6 +1798,13 @@ paint_commits(struct got_object_id_queue *ids, int *ni parents = got_object_commit_get_parent_ids(commit); if (parents) { struct got_object_qid *pid; + + STAILQ_FOREACH(pid, parents, entry) { + if (got_packidx_get_object_idx(packidx, + &pid->id) == -1) + goto send; + } + color = (intptr_t)qid->data; STAILQ_FOREACH(pid, parents, entry) { err = queue_commit_id(ids, &pid->id, color); @@ -1821,7 +1828,7 @@ paint_commits(struct got_object_id_queue *ids, int *ni if (err) goto done; } - +send: err = got_privsep_send_painted_commits(ibuf, &painted, &npainted, 1, 1); if (err) goto done;