commit 60fe0273dafb9cf4b67ad182136e740d14d709d112e79b0d76315d9ad3fb58a9 from: Stefan Sperling date: Sat Feb 1 15:28:40 2025 UTC avoid a needless check for set membership in got_pack_repaint_parent_commits() The list of ids traversed here won't contain IDs already present in the set. commit - 986deeab060e01c6985acf2405f27746018d5f7dcdf531ea1d60a78f6ea3164d commit + 60fe0273dafb9cf4b67ad182136e740d14d709d112e79b0d76315d9ad3fb58a9 blob - 2f82038137b18cc7ea5b46b02aadeaf98a8043256220750c3fba6dd7aeeda1d8 blob + 0d9091053e69d5edfc120d13be1ff3b6b33b2457990802410def2ffbbb9c5b4f --- lib/pack_create.c +++ lib/pack_create.c @@ -1095,11 +1095,9 @@ got_pack_repaint_parent_commits(struct got_object_id * break; STAILQ_REMOVE_HEAD(&ids, entry); - if (!got_object_idset_contains(set, &qid->id)) { - err = got_object_idset_add(set, &qid->id, NULL); - if (err) - break; - } + err = got_object_idset_add(set, &qid->id, NULL); + if (err) + break; err = got_object_open_as_commit(&commit, repo, &qid->id); if (err)