commit 5afd96823ab5f51c03ebf35667432f1cc12ca772 from: Tracey Emery date: Fri May 3 15:16:08 2019 UTC Stop thingsctl from trying to print out of bounds data. Weird bug! commit - bded4c93615154601875aeb9c29ce976afc2948e commit + 5afd96823ab5f51c03ebf35667432f1cc12ca772 blob - 7248b37f2a121a342ea452f17f1bd2768d3f5f3b blob + 91d9e74de7611dff9de61b9b1dbb1ba9b642f07d --- thingsctl/thingsctl.c +++ thingsctl/thingsctl.c @@ -67,7 +67,7 @@ main(int argc, char *argv[]) int n, verbose = 0; int ch; int type; - char *sockname; + char *sockname, *ctl_pkt; sockname = THINGSD_SOCK; while ((ch = getopt(argc, argv, "s:")) != -1) { @@ -183,7 +183,16 @@ main(int argc, char *argv[]) done = 1; break; } - printf("%s\n", (char *)imsg.data); + if ((ctl_pkt = calloc(IMSG_DATA_SIZE(imsg), + sizeof(*ctl_pkt))) == NULL) + errx(1, "calloc ctl_pkt"); + if ((ctl_pkt = strndup(imsg.data, + IMSG_DATA_SIZE(imsg))) == NULL) { + free(ctl_pkt); + break; + } + printf("%s\n", ctl_pkt); + free(ctl_pkt); break; case LIST_CLTS: case LIST_THGS: