commit 5a8ea86934bb484b9e31f08dbea8d5a1005482af338522f6bee7cbcb37216edd from: Stefan Sperling date: Sat Feb 1 15:34:24 2025 UTC avoid needless use of STAILQ_FOREACH_SAFE, we are not removing elements here commit - c6e7f8f0dfe9a0aba3ba692b569ab12c382b9a667f7578db55877a13b8a56320 commit + 5a8ea86934bb484b9e31f08dbea8d5a1005482af338522f6bee7cbcb37216edd blob - e33ded2b00a80849c47879d594962e1b847e3a6b9cc13b25f915fa537d0fe76f blob + 491995481b580a988c41c7f6378a85bdc3d961785cd953caaa4140f0e57df92f --- libexec/got-read-pack/got-read-pack.c +++ libexec/got-read-pack/got-read-pack.c @@ -1701,7 +1701,7 @@ repaint_parent_commits(struct got_object_id *commit_id return err; while (commit) { - struct got_object_qid *pid, *qid, *tmp; + struct got_object_qid *pid, *qid; int idx; parents = got_object_commit_get_parent_ids(commit); @@ -1765,7 +1765,7 @@ repaint_parent_commits(struct got_object_id *commit_id * In case this commit is on the caller's list of * pending commits to traverse, repaint it there. */ - STAILQ_FOREACH_SAFE(qid, ids, entry, tmp) { + STAILQ_FOREACH(qid, ids, entry) { if (got_object_id_cmp(&qid->id, &pid->id) != 0) continue; err = paint_commit(qid, color);