commit 4b5cd8d3b13fa8ea5f04de86ace3f14cbec64960f6394b9e89b55af24db011df from: Renato Aguiar via: Stefan Sperling date: Fri Jun 27 06:42:07 2025 UTC fix segfault due to double-free in got-read-gotconfig Could be triggered by running 'got fetch' with a "send" block in got.conf. The functions free_fetch_config() and free_send_config() were freeing data via the global "remote" variable instead of their own argument as intended. Patch by Renato Aguiar commit - f99fadea24254db95544b7ab122595c1785f131a2f43524168c8fba8b1bd8f45 commit + 4b5cd8d3b13fa8ea5f04de86ace3f14cbec64960f6394b9e89b55af24db011df blob - 96b6ef73d83ac3e438175fc27d078ea586e68ab682c4b0f5a8331634959a33d2 blob + 20f6f98d932e5a30ef22cf51c00c9994228ad803f7c07de2b7f3518cea56cfa8 --- libexec/got-read-gotconfig/parse.y +++ libexec/got-read-gotconfig/parse.y @@ -791,19 +791,19 @@ gotconfig_parse(struct gotconfig **conf, const char *f static void free_fetch_config(struct fetch_config *fetch_config) { - free(remote->fetch_config->repository); - free(remote->fetch_config->server); - free(remote->fetch_config->protocol); - free(remote->fetch_config); + free(fetch_config->repository); + free(fetch_config->server); + free(fetch_config->protocol); + free(fetch_config); } static void free_send_config(struct send_config *send_config) { - free(remote->send_config->repository); - free(remote->send_config->server); - free(remote->send_config->protocol); - free(remote->send_config); + free(send_config->repository); + free(send_config->server); + free(send_config->protocol); + free(send_config); } void