commit 495d04dbb73deee316ed8b2d081a9da2c9c972eda21f9dc26a6b53ea9c80f640 from: Stefan Sperling date: Fri Oct 3 10:06:51 2025 UTC reject bad hostnames provided to the gotsh weblogin command commit - c1478e141b04168ea1c07b9c2a57cb7285fa40e380d62134130e96a51808b5f1 commit + 495d04dbb73deee316ed8b2d081a9da2c9c972eda21f9dc26a6b53ea9c80f640 blob - 685180996a16b54dc3a5ea52ca51485cbc254ed07de7ce4029983bbeb0795fbd blob + f92ed2f9599076fbf2b02ffa7641c6c18cf854a131a0addd55594498392819e3 --- gotwebd/login.c +++ gotwebd/login.c @@ -513,6 +513,21 @@ client_read(struct bufferevent *bev, void *d) srv = TAILQ_FIRST(&gotwebd_env->servers); if (TAILQ_NEXT(srv, entry) == NULL) hostname = srv->name; + } else { + struct server *srv; + + /* Match hostname against available servers. */ + TAILQ_FOREACH(srv, &gotwebd_env->servers, entry) { + if (strcmp(srv->name, hostname) == 0) + break; + } + + if (srv == NULL) { + log_warnx("%s: bad hostname for weblogin: %s", + __func__, hostname); + client_err(bev, EVBUFFER_READ, client); + return; + } } code = login_gen_token(client->euid, hostname,