commit 41170ccf58db6400db78725644f836a84e3430c0e5e367e4b11020be29aee9db from: Stefan Sperling date: Tue Jan 27 10:44:31 2026 UTC fix bugs in "foo" <-> "foo.git" comparison functions commit - 7290b45d342a107e5bddd49dc8b81df046c957db7fdd625377f69e452f6e097f commit + 41170ccf58db6400db78725644f836a84e3430c0e5e367e4b11020be29aee9db blob - ea147120e7283a0480f21f3e58234398d33cfca0cf77b2dbc466f1c1f526c810 blob + 47c98dd7533f15157c3bc9aac372074ab5f5eedaafe54887ffb6a7a623fb5a6f --- gotd/parse.y +++ gotd/parse.y @@ -1765,18 +1765,19 @@ gotd_find_repo_by_name(const char *repo_name, struct g MINIMUM(needle_len, haystack_len)) != 0) continue; - if (repo_name[needle_len] == '\0' && + if (needle_len == haystack_len && + repo_name[needle_len] == '\0' && repo->name[haystack_len] == '\0') return repo; if (repo_name[needle_len] == '\0' && - haystack_len > 4 && - strcmp(&repo->name[haystack_len], ".git") == 0) + haystack_len == needle_len + 4 && + strcmp(&repo->name[haystack_len - 4], ".git") == 0) return repo; if (repo->name[haystack_len] == '\0' && - needle_len > 4 && - strcmp(&repo_name[needle_len], ".git") == 0) + needle_len == haystack_len + 4 && + strcmp(&repo_name[needle_len - 4], ".git") == 0) return repo; } blob - 9c735dbb80afcc3aaf19f833f28429cd7e5fe3b132bb8f4e8e46f2950a11aac1 blob + 2a54d1394a91b92f21676289e34ddc3999bae99405222d6047d303cb76b045b5 --- lib/gotsys_conf.c +++ lib/gotsys_conf.c @@ -1368,18 +1368,19 @@ gotsys_find_repo_by_name(const char *repo_name, struct MINIMUM(needle_len, haystack_len)) != 0) continue; - if (repo_name[needle_len] == '\0' && + if (needle_len == haystack_len && + repo_name[needle_len] == '\0' && repo->name[haystack_len] == '\0') return repo; if (repo_name[needle_len] == '\0' && - haystack_len > 4 && - strcmp(&repo->name[haystack_len], ".git") == 0) + haystack_len == needle_len + 4 && + strcmp(&repo->name[haystack_len - 4], ".git") == 0) return repo; if (repo->name[haystack_len] == '\0' && - needle_len > 4 && - strcmp(&repo_name[needle_len], ".git") == 0) + needle_len == haystack_len + 4 && + strcmp(&repo_name[needle_len - 4], ".git") == 0) return repo; } @@ -1400,17 +1401,18 @@ gotsys_find_webrepo_by_name(const char *repo_name, MINIMUM(needle_len, haystack_len)) != 0) continue; - if (repo_name[needle_len] == '\0' && + if (needle_len == haystack_len && + repo_name[needle_len] == '\0' && webrepo->repo_name[haystack_len] == '\0') return webrepo; if (repo_name[needle_len] == '\0' && - haystack_len > 4 && + haystack_len == needle_len + 4 && strcmp(&webrepo->repo_name[haystack_len - 4], ".git") == 0) return webrepo; if (webrepo->repo_name[haystack_len] == '\0' && - needle_len > 4 && + needle_len == haystack_len + 4 && strcmp(&repo_name[needle_len - 4], ".git") == 0) return webrepo; }