commit 331a7a534d021bf36ec8ff2c8b4885f1a51c5951c03ab7b9ea3884cef4f4ef18 from: Stefan Sperling date: Wed Oct 14 12:23:16 2026 UTC use PATH_MAX instead of _POSIX_PATH_MAX because the latter is too small libc APIs such as realpath(3) implicitly assume an output buffer which can store at least PATH_MAX bytes. Using _POSIX_PATH_MAX instead is not safe for such APIs. Pointed out by martijn@, discussed with thomas adam for -portable commit - ec26929e015920fa60766b5fcd9baa504368d0dcd68e9f0c42c3c9bba9e5faff commit + 331a7a534d021bf36ec8ff2c8b4885f1a51c5951c03ab7b9ea3884cef4f4ef18 blob - 2bd0ac207a8a992374227e20e0bc16214f7b4d622c0cfc20be46e9d25ddd36ab blob + 1947a2a2ee3c7a092221ad6ba9ef6268650f73df8f034635a5707c5845baf6c2 --- gotsysd/gotsysd.h +++ gotsysd/gotsysd.h @@ -183,8 +183,8 @@ struct gotsysd_web_config { struct gotsysd { pid_t pid; - char unix_socket_path[_POSIX_PATH_MAX]; - char repos_path[_POSIX_PATH_MAX]; + char unix_socket_path[PATH_MAX]; + char repos_path[PATH_MAX]; char user_name[32]; char gotd_username[32]; char gotsys_conf_commit_id[GOT_OBJECT_ID_HEX_MAXLEN]; @@ -399,7 +399,7 @@ struct gotsysd_imsg_auth { struct gotsysd_imsg_info { pid_t pid; int verbosity; - char repository_directory[_POSIX_PATH_MAX]; + char repository_directory[PATH_MAX]; uid_t uid_start; uid_t uid_end; struct got_object_id commit_id; blob - c1f4bd95090512a2d798ee060c4102278387cf5fee7a0cfbec96cbdb88a78e71 blob + cc95f5c34936825eb7393937e3bc2f5d2d255344148d1ae5daf44edbe5ccefc9 --- gotsysd/helpers.c +++ gotsysd/helpers.c @@ -48,7 +48,7 @@ struct gotsysd_helper_proc { pid_t pid; enum gotsysd_imsg_type type; - char progname[_POSIX_PATH_MAX]; + char progname[PATH_MAX]; int pipe[2]; int fd; struct gotsysd_imsgev iev; blob - efd061a7a9f7112cf5445628c0603774ca2fc0b4191329fb12f59c668de9171c blob + 120c22176c6685af01be9ed63af074b015597c4756cfe8d9968d9f2b2ec3e347 --- gotsysd/libexec/gotsys-repo-create/gotsys-repo-create.c +++ gotsysd/libexec/gotsys-repo-create/gotsys-repo-create.c @@ -56,7 +56,7 @@ #include "gotsys.h" static struct gotsys_conf gotsysconf; -static char repos_path[_POSIX_PATH_MAX]; +static char repos_path[PATH_MAX]; static int repos_dir_fd = -1; uid_t gotd_uid; gid_t gotd_gid; @@ -114,7 +114,7 @@ static const struct got_error * set_head_ref(int repos_dir_fd, const char *repo_name, const char *refname) { const struct got_error *err = NULL; - char relpath[_POSIX_PATH_MAX]; + char relpath[PATH_MAX]; struct got_lockfile *lf = NULL; int ret, fd = -1; struct stat sb; blob - 6e9e93efaf8b61858626496dd5d84f2ebd2f13a9b485747068a2cf98062010e0 blob + 31a6d03091a4178ae1fa9b83b54c84969901a447263b548f02502427b79e5b31 --- gotsysd/libexec/gotsys-rmkeys/gotsys-rmkeys.c +++ gotsysd/libexec/gotsys-rmkeys/gotsys-rmkeys.c @@ -87,7 +87,7 @@ remove_keys(void) { const struct got_error *err = NULL; struct passwd *pw = NULL; - char authorized_keys_path[_POSIX_PATH_MAX]; + char authorized_keys_path[PATH_MAX]; /* * Remove keys of users in our UID range no longer mentioned blob - 08b340d763b1a630ff1e8dc868714d99caf3e7dccfffc3933ae3c7d36d37b2d9 blob + 3aa17c316344a13fd879844f1adbb1a84eb5c8d96febab422e2eb1fae457123e --- gotsysd/libexec/gotsys-userhome/gotsys-userhome.c +++ gotsysd/libexec/gotsys-userhome/gotsys-userhome.c @@ -80,7 +80,7 @@ static const struct got_error * createhome(const char *username, uid_t uid, gid_t gid) { const struct got_error *err = NULL; - char path[_POSIX_PATH_MAX]; + char path[PATH_MAX]; int ret; ret = snprintf(path, sizeof(path), "%s/%s", GOTSYSD_HOMEDIR, blob - dfc3443350c8440bdce5719a7b5726285cbbd0aa0481a3ef673b9f8e956882da blob + 195797b67bedfefc26c87c30f054e08ff1285cabc11b430d58343333b6aeedf5 --- gotsysd/libexec/gotsys-userkeys/gotsys-userkeys.c +++ gotsysd/libexec/gotsys-userkeys/gotsys-userkeys.c @@ -47,7 +47,7 @@ #include "gotwebd.h" #include "gotsys.h" -static char authorized_keys_path[_POSIX_PATH_MAX]; +static char authorized_keys_path[PATH_MAX]; static char *authorized_keys_tmppath; static int authorized_keys_tmpfd = -1; struct gotsys_authorized_keys_list authorized_keys; blob - 579422dc90d65b39f7bba6f334452062eebe3a3ea376e2f8941536ec092eec7d blob + 6f02d3e85ce429659d9ee85309a745f868d8d4aa836afea352328fbb7fd8277b --- gotsysd/libexec/gotsys-write-conf/gotsys-write-conf.c +++ gotsysd/libexec/gotsys-write-conf/gotsys-write-conf.c @@ -831,7 +831,7 @@ write_gotd_conf(int *auth_idx) const struct got_error *err = NULL; struct gotsys_repo *repo; int ret; - char repo_path[_POSIX_PATH_MAX]; + char repo_path[PATH_MAX]; struct timespec now; err = got_opentemp_truncatefd(gotd_conf_tmpfd); @@ -1022,7 +1022,7 @@ write_implicit_clone_url(int fd, const char *path, con const char *full_repo_name) { const struct got_error *err; - char repo_name[_POSIX_PATH_MAX]; + char repo_name[PATH_MAX]; int ret; err = canon_repo_name(repo_name, sizeof(repo_name), full_repo_name); @@ -1092,7 +1092,7 @@ write_webrepo(int *show_repo_description, int *login_h const struct got_error *err; struct gotsys_repo *repo; int ret; - char repo_name[_POSIX_PATH_MAX]; + char repo_name[PATH_MAX]; int have_login_hint_user = 0; int login_hint_user_has_repo_access = 0; @@ -1193,7 +1193,7 @@ write_website(int *login_hint_user_access, int fd, con { const struct got_error *err; int ret; - char repo_name[_POSIX_PATH_MAX]; + char repo_name[PATH_MAX]; int have_login_hint_user = 0; ret = dprintf(fd, "\twebsite \"%s\" {\n", site->url_path); blob - c8c047ca1f3587958b6505e3da87d3768b579f40f66a9148857ad48ca80abd3f blob + 663770c43362a1d9ea69c3be739096709c8e3810ba0a7ad01b6d84ea5766cea4 --- gotwebd/parse.y +++ gotwebd/parse.y @@ -1839,7 +1839,7 @@ parse_config(const char *filename, struct gotwebd *env /* add the implicit listen on socket */ if (TAILQ_EMPTY(&gotwebd->addresses)) { - char path[_POSIX_PATH_MAX]; + char path[PATH_MAX]; struct address *h; if (strlcpy(path, gotwebd->httpd_chroot, sizeof(path))