commit 10b6598850427d69f6ae4ef9b10c4bbf7d0d55f282f04242cf22f1a7157fe026 from: Stefan Sperling date: Sat Oct 10 10:01:58 2026 UTC fix commit ID buffer size in write_gotsys_db_file() and fix a length check commit - 27fdcf6761993fa847b77cc99c7b06f4899a67c7d6276b6b6f895d702e56a01e commit + 10b6598850427d69f6ae4ef9b10c4bbf7d0d55f282f04242cf22f1a7157fe026 blob - ddca0b4c0099653633d4b29c94a1e52d27cb5d3e0f62f3abb64a4de8c60ee294 blob + 38201afa141c0fafecfa18c5cda6fcc0269d45c6b35b55c47fc1d9efde147419 --- gotsysd/gotsysd.c +++ gotsysd/gotsysd.c @@ -412,7 +412,7 @@ connect_proc(struct gotsysd_child_proc *proc1, static const struct got_error * write_gotsys_db_file(void) { - char buf[GOT_OBJECT_ID_HEX_MAXLEN]; + char buf[GOT_OBJECT_ID_HEX_MAXLEN + 1]; /* hex\0 + \n */ ssize_t w; size_t len; int ret; @@ -426,7 +426,7 @@ write_gotsys_db_file(void) return got_error_from_errno2("lseek", GOTSYSD_DB_COMMIT_PATH); len = strlen(gotsysd.sysconf_commit_id_str); - if (len == 0 || len > GOT_OBJECT_ID_HEX_MAXLEN) + if (len == 0 || len >= GOT_OBJECT_ID_HEX_MAXLEN) return got_error(GOT_ERR_BAD_OBJ_ID_STR); ret = snprintf(buf, sizeof(buf), "%s\n", gotsysd.sysconf_commit_id_str);