commit 05c041efa065bfbf199159907cdf00275c62e958e672d29ddfe8b1ea77e1ae9f from: Stefan Sperling date: Thu Jan 30 13:22:47 2025 UTC fix a double-free introduced with changes to got-read-pack coloring commit - 0cc242f13fc0e4d66aa1164fb0c1d27719a7d167f21535cff10eba74644893ad commit + 05c041efa065bfbf199159907cdf00275c62e958e672d29ddfe8b1ea77e1ae9f blob - 9e6e6f199381538103a9ebe7068470b3c2f149b3c145c1efdab71a054ee155dd blob + 1a1a88e8c99433f188ca00b10b35513ad1979c4467a6ebc75593df7412b5bb41 --- lib/pack_create_privsep.c +++ lib/pack_create_privsep.c @@ -481,7 +481,7 @@ got_pack_paint_commits(int *ncolored, struct got_objec ids, keep, drop, skip, repo, progress_cb, progress_arg, rl, cancel_cb, cancel_arg); - if (err) + if (err && qid == NULL) goto done; if (qid) { STAILQ_REMOVE(ids, qid, @@ -489,6 +489,8 @@ got_pack_paint_commits(int *ncolored, struct got_objec nqueued--; got_object_qid_free(qid); qid = NULL; + if (err) + goto done; } continue; }